From ff112ce89032b0c75fbd14946d3beb620fb84ed0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonardo=20Mur=C3=A7a?= Date: Sat, 19 Jul 2025 17:51:49 -0300 Subject: [PATCH] refactor: make functions private and extract constant --- .../ui/screens/matchdetails/MatchDetailsScreen.kt | 2 +- .../csgomatches/ui/screens/matches/MatchesScreen.kt | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/xyz/leomurca/csgomatches/ui/screens/matchdetails/MatchDetailsScreen.kt b/app/src/main/java/xyz/leomurca/csgomatches/ui/screens/matchdetails/MatchDetailsScreen.kt index 44a5561..1c62b31 100644 --- a/app/src/main/java/xyz/leomurca/csgomatches/ui/screens/matchdetails/MatchDetailsScreen.kt +++ b/app/src/main/java/xyz/leomurca/csgomatches/ui/screens/matchdetails/MatchDetailsScreen.kt @@ -90,7 +90,7 @@ fun MatchDetailsScreen( } @Composable -fun DualPlayerLists( +private fun DualPlayerLists( leftPlayers: List, rightPlayers: List, modifier: Modifier = Modifier diff --git a/app/src/main/java/xyz/leomurca/csgomatches/ui/screens/matches/MatchesScreen.kt b/app/src/main/java/xyz/leomurca/csgomatches/ui/screens/matches/MatchesScreen.kt index e15f952..c18523a 100644 --- a/app/src/main/java/xyz/leomurca/csgomatches/ui/screens/matches/MatchesScreen.kt +++ b/app/src/main/java/xyz/leomurca/csgomatches/ui/screens/matches/MatchesScreen.kt @@ -35,6 +35,8 @@ import xyz.leomurca.csgomatches.ui.navigation.MatchDetailsRoute import xyz.leomurca.csgomatches.ui.screens.matches.MatchesViewModel.MatchesUiState import xyz.leomurca.csgomatches.ui.theme.White +private const val ITEMS_PAGINATION_THRESHOLD = 3 + @OptIn(ExperimentalMaterial3Api::class) @Composable fun MatchesScreen( @@ -49,7 +51,7 @@ fun MatchesScreen( snapshotFlow { listState.layoutInfo.visibleItemsInfo.lastOrNull()?.index } .collect { lastVisibleIndex -> val totalItems = listState.layoutInfo.totalItemsCount - if (lastVisibleIndex != null && lastVisibleIndex >= totalItems - 3) { + if (lastVisibleIndex != null && lastVisibleIndex >= totalItems - ITEMS_PAGINATION_THRESHOLD) { viewModel.loadNextPage() } } @@ -103,7 +105,7 @@ fun MatchesScreen( } @Composable -fun MatchesList( +private fun MatchesList( matches: List, onTapCard: (MatchDetailsRoute) -> Unit, listState: LazyListState,